Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped ready-mode send tests #43

Open
dssgabriel opened this issue May 6, 2024 · 0 comments
Open

Skipped ready-mode send tests #43

dssgabriel opened this issue May 6, 2024 · 0 comments

Comments

@dssgabriel
Copy link
Collaborator

PR #30 skips tests for ready-mode send operations as we lack irecv to correctly test the ready-mode send and isend functions.

Unit tests should look something like the following:

if (rank == 0) {
  // Ensure `irecv` has started when we exit the following barrier
  KokkosComm::Impl::barrier(Kokkos::DefaultExecutionSpace(), MPI_COMM_WORLD);

  // Send the view
  KokkosComm::send<KokkosComm::CommMode::Ready>(
    Kokkos::DefaultExecutionSpace(),
    view,
    dst,
    tag,
    MPI_COMM_WORLD
  );
} else {
  // Start reception
  auto req = KokkosComm::irecv(
    Kokkos::DefaultExecutionSpace(),
    view,
    src,
    tag,
    MPI_COMM_WORLD
  );

  // Barrier guaranteeing to the sender (rank 0) that the recipient (rank 1) is ready
  KokkosComm::Impl::barrier(Kokkos::DefaultExecutionSpace(), MPI_COMM_WORLD);

  // Wait until receive completion
  req.wait();
}

These tests should not be skipped anymore once #32 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant