New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests call Impl::irecv , KokkosComm::irecv takes MPI_Request by value rather than reference #91

Open

nicoleavans opened this issue Jun 18, 2024 · 1 comment

Collaborator

nicoleavans commented Jun 18, 2024

The unit tests passed when merging a broken implementation of KokkosComm::irecv because they directly call Impl::irecv, which works correctly.

kokkos-comm/src/KokkosComm.hpp

Line 39 in dd3c5c4

void irecv(RecvView &rv, int src, int tag, MPI_Comm comm, MPI_Request req) {

I have submitted #90 to resolve this issue.

Collaborator

dssgabriel commented Jun 19, 2024

Partially fixed in #92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment