From 25c0d65c53ff84d1f5bb86cb087b970df86a60f3 Mon Sep 17 00:00:00 2001 From: Vivek Kale <11766050+vlkale@users.noreply.github.com> Date: Mon, 1 Apr 2024 15:02:36 -0700 Subject: [PATCH 1/4] kp_core.hpp: remove pointer from ptpi --- profiling/all/kp_core.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/profiling/all/kp_core.hpp b/profiling/all/kp_core.hpp index c63db1863..77193e901 100644 --- a/profiling/all/kp_core.hpp +++ b/profiling/all/kp_core.hpp @@ -55,7 +55,7 @@ using Kokkos::Tools::SpaceHandle; #define EXPOSE_PROVIDE_TOOL_PROGRAMMING_INTERFACE(FUNC_NAME) \ __attribute__((weak)) void kokkosp_provide_tool_programming_interface( \ const uint32_t num_actions, \ - Kokkos_Tools_ToolProgrammingInterface* ptpi) { \ + Kokkos_Tools_ToolProgrammingInterface ptpi) { \ FUNC_NAME(num_actions, ptpi); \ } From 152bf841cc97adb5ec3af0e8e9e68d7fd0db7007 Mon Sep 17 00:00:00 2001 From: Vivek Kale <11766050+vlkale@users.noreply.github.com> Date: Mon, 1 Apr 2024 15:18:50 -0700 Subject: [PATCH 2/4] kp_sampler_skip.cpp: pass by value kokkosp_p_t_p_i kp_sampler_skip.cpp: last parameter should be passed by value rather than pointer in kokkosp_p_t_p_i --- common/kokkos-sampler/kp_sampler_skip.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/kokkos-sampler/kp_sampler_skip.cpp b/common/kokkos-sampler/kp_sampler_skip.cpp index d56ed84ca..5ab4bcf43 100644 --- a/common/kokkos-sampler/kp_sampler_skip.cpp +++ b/common/kokkos-sampler/kp_sampler_skip.cpp @@ -64,7 +64,7 @@ void invoke_ktools_fence(uint32_t devID) { } void kokkosp_provide_tool_programming_interface( - uint32_t num_funcs, Kokkos_Tools_ToolProgrammingInterface* funcsFromTPI) { + uint32_t num_funcs, Kokkos_Tools_ToolProgrammingInterface funcsFromTPI) { if (!num_funcs) { if (tool_verbosity > 0) printf( From 2839954687706f08483d7caa49ca406d3f015a09 Mon Sep 17 00:00:00 2001 From: Vivek Kale <11766050+vlkale@users.noreply.github.com> Date: Mon, 1 Apr 2024 15:23:50 -0700 Subject: [PATCH 3/4] kp_sampler_skip.cpp: remove dereference assignment for ptpi callback --- common/kokkos-sampler/kp_sampler_skip.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/kokkos-sampler/kp_sampler_skip.cpp b/common/kokkos-sampler/kp_sampler_skip.cpp index 5ab4bcf43..81401ff31 100644 --- a/common/kokkos-sampler/kp_sampler_skip.cpp +++ b/common/kokkos-sampler/kp_sampler_skip.cpp @@ -71,7 +71,7 @@ void kokkosp_provide_tool_programming_interface( "KokkosP: Note: Number of functions in Tools Programming Interface " "is 0!\n"); } - tpi_funcs = *funcsFromTPI; + tpi_funcs = funcsFromTPI; } void kokkosp_init_library(const int loadSeq, const uint64_t interfaceVer, From bac317d0e62358ab620fe6d62f272bf8f499bbc9 Mon Sep 17 00:00:00 2001 From: Vivek Kale <11766050+vlkale@users.noreply.github.com> Date: Mon, 1 Apr 2024 15:36:19 -0700 Subject: [PATCH 4/4] kp_core.hpp: apply clang-format --- profiling/all/kp_core.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/profiling/all/kp_core.hpp b/profiling/all/kp_core.hpp index 77193e901..cc51bc3d9 100644 --- a/profiling/all/kp_core.hpp +++ b/profiling/all/kp_core.hpp @@ -55,7 +55,7 @@ using Kokkos::Tools::SpaceHandle; #define EXPOSE_PROVIDE_TOOL_PROGRAMMING_INTERFACE(FUNC_NAME) \ __attribute__((weak)) void kokkosp_provide_tool_programming_interface( \ const uint32_t num_actions, \ - Kokkos_Tools_ToolProgrammingInterface ptpi) { \ + Kokkos_Tools_ToolProgrammingInterface ptpi) { \ FUNC_NAME(num_actions, ptpi); \ }