Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom annotations and labels on Pods #9

Open
AndresPineros opened this issue Dec 15, 2018 · 3 comments
Open

Allow custom annotations and labels on Pods #9

AndresPineros opened this issue Dec 15, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@AndresPineros
Copy link

The only way to monitor what the descheduler does to the cluster is by checking the logs. For most logging tools for Kubernetes (for example Kibana), labels and annotations are critical to filter information.

Maybe something like:

...
...
...
spec:
  schedule: "{{ .Values.schedule }}"
  jobTemplate:
    metadata:
      labels:
{{ if .Values.labels }}{{ toYaml .Values.labels | indent 8 }}{{end}}
        app: {{ template "descheduler.name" . }}
        release: {{ .Release.Name }}
      annotations:
{{ if .Values.annotations }}{{ toYaml .Values.annotations | indent 8 }}{{end}}
        scheduler.alpha.kubernetes.io/critical-pod: "true"
        checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
    spec:
      template:
        metadata:
          labels:
{{ if .Values.labels }}{{ toYaml .Values.labels | indent 12 }}{{end}}
            app: {{ template "descheduler.name" . }}
            release: {{ .Release.Name }}
          annotations:
{{ if .Values.annotations }}{{ toYaml .Values.annotations | indent 12 }}{{end}}
            scheduler.alpha.kubernetes.io/critical-pod: "true"
            checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
        spec:
...
...
...
@komljen
Copy link
Owner

komljen commented Dec 15, 2018

Could you create a PR for this?

@AndresPineros
Copy link
Author

Sure!

@AndresPineros
Copy link
Author

#10

@komljen komljen added the enhancement New feature or request label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants