Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deployment of newer NiFi Registry Client types #509

Open
ChrisSamo632 opened this issue Feb 3, 2025 · 2 comments
Open

Allow deployment of newer NiFi Registry Client types #509

ChrisSamo632 opened this issue Feb 3, 2025 · 2 comments
Labels
community enhancement New feature or request

Comments

@ChrisSamo632
Copy link

Is your feature request related to a problem?

NiFi Registry Clients deployed by NiFiKop are currently limited to the original "NiFi Registry" type

Describe the solution you'd like to see

Support newer types of Registry Client, e.g. GitHub, GitLab, BitBucket

Would need to allow for different settings for each type of Registry Client

Describe alternatives you've considered

  • Manually configuring the NiFi Registry Client within the deployment
  • Using NiFi Toolkit/NiPyApi to script the connectivity as part of a post-deployment Job

Additional context

No response

@ChrisSamo632 ChrisSamo632 added community enhancement New feature or request labels Feb 3, 2025
@juldrixx
Copy link
Contributor

juldrixx commented Feb 3, 2025

It was in my todo list (but time issue 😄) and we even thought to try to implement a new FlowRegistry to use ConfigMaps possibly. But yes, it could be interesting to implement it.

But a choice needs to be made, whether we implement a specifc ressource for each FlowRegistry type or if we create a generic one like NifiFlowRegistryClient and replace the NifiRegistryClient by it.

Personnaly, I prefer the second option.

@ChrisSamo632
Copy link
Author

It was in my todo list (but time issue 😄) and we even thought to try to implement a new FlowRegistry to use ConfigMaps possibly. But yes, it could be interesting to implement it.

But a choice needs to be made, whether we implement a specifc ressource for each FlowRegistry type or if we create a generic one like NifiFlowRegistryClient and replace the NifiRegistryClient by it.

Personnaly, I prefer the second option.

A new ConfigMap based Flow Registry sounds interesting - certainly one to bear in mind for future implementations.

I think aiming for the second approach would seem better, if there's a way to achieve that without bloating the resource definition too much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants