Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to get DST to determine the continent? #5

Open
m33ts4k0z opened this issue Mar 16, 2019 · 2 comments
Open

Any way to get DST to determine the continent? #5

m33ts4k0z opened this issue Mar 16, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@m33ts4k0z
Copy link

Hello and thanks for this library.

I wonder if there is a way to get even the DST from the scrapped data since openflights provide this as well.

Thanks

@konsalex konsalex added the enhancement New feature or request label Mar 16, 2019
@konsalex
Copy link
Owner

Yes for sure this is easy to be done.
I cannot include this in the package because fetching extra data like DST means extra loading time.

But you can extract them easily by running airportsFetch.py, and adding one more like
unique_airport["DST"] = values[<The DST place>].replace('"', '').strip()

I am curious though how are you going to use DST @m33ts4k0z 🧐

@m33ts4k0z
Copy link
Author

m33ts4k0z commented Mar 18, 2019

Thanks for you answer

I will pass the DST as a data value and I will use it on my controller in order to determine the continent of the airport.

I managed to fix it but there was a small bug in the generated json:

I had to bracket the airports in an {"airports": } otherwise I got an error.

Also did I do it correctly? I replaced the url in index.browser.min.js. Is that the way you meant to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants