Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that usage/registration of custom URL resolver is clear enough #322

Open
MiroKentico opened this issue Mar 3, 2022 · 1 comment

Comments

@MiroKentico
Copy link
Contributor

MiroKentico commented Mar 3, 2022

In the past, developer wanted to register and use custom implementation of custom URL resolver based on https://kontent.ai/learn/tutorials/develop-apps/get-content/structured-rich-text/?tech=dotnet#a-resolve-hyperlinks-to-content-items.

Unfortunately his implementation combined usage of DeliveryClientBuilder methods WithContentLinkUrlResolver and WithModelProvider. Developer expectation was, that custom URL resolver set by WithContentLinkUrlResolver will be used, but that didn't happen. It seems that root cause of this was, that his custom model provider set by WithModelProvider internally used different collection of URL resolvers (maybe even empty ?).

I would like to check and ensure that the implementation of this URL resolver usage code is clear, and so it should be our Wiki. Maybe just a simple note on this topic added into our Wiki might prevent similar situations in future.

@Simply007
Copy link
Contributor

might be related to #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants