Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFP] Replace LI's object with interface in delivery models #162

Open
Sevitas opened this issue Sep 8, 2022 · 1 comment
Open

[RFP] Replace LI's object with interface in delivery models #162

Sevitas opened this issue Sep 8, 2022 · 1 comment

Comments

@Sevitas
Copy link
Contributor

Sevitas commented Sep 8, 2022 •
edited
Loading

Proposed solution

Replace LI's IEnumerable<object> with IEnumerable<IContentItem> for delivery models. Causing a breaking change for delivery models.

Additional context

Be aware that this will intorduce a breaking change.
IContentItem will be created in #90.
Blocked by #90.
@Sevitas Sevitas added the blocked label Sep 8, 2022
@Sevitas Sevitas changed the title Replace LI's object with interface Replace LI's object with interface in delivery models Sep 8, 2022
@Sevitas
Copy link
Contributor Author

Sevitas commented Mar 9, 2023

Interface IContentItem was created as part of Delivery.Abstractions kontent-ai/delivery-sdk-net#368.
Support for generating models implementing IContentItem interface and replacing object of modular content elements with IContentItem will be done as part of #90 using the structuredModel option.

@Sevitas Sevitas changed the title Replace LI's object with interface in delivery models [RFP] Replace LI's object with interface in delivery models Mar 24, 2023
@Sevitas Sevitas removed the blocked label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sevitas