Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail when dependency SHA cannot be read from file #175

Closed
pranavgaikwad opened this issue May 24, 2023 · 7 comments
Closed

Do not fail when dependency SHA cannot be read from file #175

pranavgaikwad opened this issue May 24, 2023 · 7 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@pranavgaikwad
Copy link
Contributor

Right now, we fail and return if any one dependency SHA cant be found. We need to continue looking at other deps.
@pranavgaikwad pranavgaikwad added the kind/bug Categorizes issue or PR as related to a bug. label May 24, 2023
@pranavgaikwad pranavgaikwad moved this to 🆕 New in Konveyor Analyzers May 24, 2023
@pranavgaikwad pranavgaikwad moved this from 🆕 New to 📋 TODO in Konveyor Analyzers May 24, 2023
@pranavgaikwad pranavgaikwad added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 24, 2023
@shawn-hurley
Copy link
Contributor

you can find this code specifically for the java provider here:
https://github.com/konveyor/analyzer-lsp/blob/main/provider/internal/java/dependency.go#L202

@punithnayak
Copy link

Hey @pranavgaikwad Can i take up this issue..

@pranavgaikwad
Copy link
Contributor Author

@punithnayak thank you! please take it away

@punithnayak
Copy link

Hey @pranavgaikwad
image
Facing this issue

@punithnayak
Copy link

Hey @pranavgaikwad can you please tell me how resolve this issue

@shawn-hurley
Copy link
Contributor

I think that you need to add docker.io as a registry

@Parthiba-Hazra Parthiba-Hazra mentioned this issue Jul 27, 2023
Merged
pranavgaikwad pushed a commit that referenced this issue Jul 27, 2023
@Parthiba-Hazra
🐛 Not to fail when dependency SHA cannot be read from file. (#272)
86939ec 
Hey in failure scenario I set `d.ResolvedIdentifier` as an empty string
(d.ResolvedIdentifier = "").
Let me know if I need to set it to any other value.
I think this is the only function that need to update maybe have to
update also `parseMavenDepLines` function .. let me know if I am wrong.

Issue: #175

---------

Signed-off-by: Parthiba-Hazra <[email protected]>
@pranavgaikwad
Copy link
Contributor Author

Fixed via #272

@github-project-automation github-project-automation bot moved this from 📋 TODO to ✅ Done in Konveyor Analyzers Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Konveyor Analyzers
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shawn-hurley @pranavgaikwad @punithnayak