diff --git a/.github/workflows/pr-closed.yaml b/.github/workflows/pr-closed.yaml new file mode 100644 index 0000000000..41afa19e6c --- /dev/null +++ b/.github/workflows/pr-closed.yaml @@ -0,0 +1,16 @@ +name: PR Closed + +on: + pull_request_target: + branches: + - main + types: + - closed + +jobs: + cherry_pick_job: + permissions: + pull-requests: write + contents: write + if: github.event.pull_request.merged == true + uses: konveyor/release-tools/.github/workflows/cherry-pick.yml@main diff --git a/client/public/locales/en/translation.json b/client/public/locales/en/translation.json index b7621ed97f..f97c91fc29 100644 --- a/client/public/locales/en/translation.json +++ b/client/public/locales/en/translation.json @@ -437,6 +437,7 @@ "teamMember": "team member", "ticket": "Ticket", "trivialButMigratable": "Trivial but migratable", + "unassessedOrUnknown": "Unassessed or unknown", "unassessed": "Unassessed", "unassigned": "Not yet assigned", "unknown": "Unknown", diff --git a/client/src/app/pages/applications/applications-table/applications-table.tsx b/client/src/app/pages/applications/applications-table/applications-table.tsx index 62386a672b..13d6b52ffe 100644 --- a/client/src/app/pages/applications/applications-table/applications-table.tsx +++ b/client/src/app/pages/applications/applications-table/applications-table.tsx @@ -54,16 +54,12 @@ import keycloak from "@app/keycloak"; import { RBAC, RBAC_TYPE, - analysisReadScopes, - analysisWriteScopes, + analysesReadScopes, applicationsWriteScopes, - assessmentReadScopes, assessmentWriteScopes, credentialsReadScopes, - credentialsWriteScopes, dependenciesWriteScopes, importsWriteScopes, - reviewsReadScopes, reviewsWriteScopes, tasksReadScopes, tasksWriteScopes, @@ -542,16 +538,12 @@ export const ApplicationsTable: React.FC = () => { importWriteAccess = checkAccess(userScopes, importsWriteScopes), applicationWriteAccess = checkAccess(userScopes, applicationsWriteScopes), assessmentWriteAccess = checkAccess(userScopes, assessmentWriteScopes), - analysisWriteAccess = checkAccess(userScopes, analysisWriteScopes), - assessmentReadAccess = checkAccess(userScopes, assessmentReadScopes), credentialsReadAccess = checkAccess(userScopes, credentialsReadScopes), - credentialsWriteAccess = checkAccess(userScopes, credentialsWriteScopes), dependenciesWriteAccess = checkAccess(userScopes, dependenciesWriteScopes), - analysisReadAccess = checkAccess(userScopes, analysisReadScopes), + analysesReadAccess = checkAccess(userScopes, analysesReadScopes), tasksReadAccess = checkAccess(userScopes, tasksReadScopes), tasksWriteAccess = checkAccess(userScopes, tasksWriteScopes), - reviewsWriteAccess = checkAccess(userScopes, reviewsWriteScopes), - reviewsReadAccess = checkAccess(userScopes, reviewsReadScopes); + reviewsWriteAccess = checkAccess(userScopes, reviewsWriteScopes); const areAppsInWaves = selectedRows.some( (application) => application.migrationWave !== null @@ -1031,7 +1023,7 @@ export const ApplicationsTable: React.FC = () => { }, ] : []), - ...(analysisReadAccess && hasExistingAnalysis + ...(analysesReadAccess && hasExistingAnalysis ? [ { title: t("actions.analysisDetails"), diff --git a/client/src/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx b/client/src/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx index 15144d45d8..f3b393e913 100644 --- a/client/src/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx +++ b/client/src/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx @@ -21,6 +21,7 @@ import { Divider, Tooltip, Label, + LabelGroup, } from "@patternfly/react-core"; import spacing from "@patternfly/react-styles/css/utilities/Spacing/spacing"; import { @@ -210,16 +211,18 @@ export const ApplicationDetailDrawer: React.FC< {t("terms.archetypesAssessed")} - {assessedArchetypes?.length ? ( - assessedArchetypes.map((assessedArchetype) => ( - - )) - ) : ( - - )} + + {assessedArchetypes?.length ? ( + assessedArchetypes.map((assessedArchetype) => ( + + )) + ) : ( + + )} + @@ -228,16 +231,18 @@ export const ApplicationDetailDrawer: React.FC< {t("terms.archetypesReviewed")} - {reviewedArchetypes?.length ? ( - reviewedArchetypes.map((reviewedArchetype) => ( - - )) - ) : ( - - )} + + {reviewedArchetypes?.length ? ( + reviewedArchetypes.map((reviewedArchetype) => ( + + )) + ) : ( + + )} + diff --git a/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx b/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx index 6e7fb43264..6637c350e8 100644 --- a/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx +++ b/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx @@ -186,7 +186,7 @@ export const ApplicationLandscape: React.FC = ({ = ({ {`${t("terms.unassessed")}/${t("terms.unknown")}`} } - riskTitle={t("terms.unassessed")} + riskTitle={t("terms.unassessedOrUnknown")} /> diff --git a/client/src/app/rbac.ts b/client/src/app/rbac.ts index cf136ff19e..5f1aa09b3e 100644 --- a/client/src/app/rbac.ts +++ b/client/src/app/rbac.ts @@ -110,18 +110,7 @@ export const archetypesWriteScopes = [ "archetypes:delete", ]; -export const analysisWriteScopes = [ - "applications.analysis:put", - "applications.analysis:post", - "applications.analysis:delete", - "archetypes.analysis:put", - "archetypes.analysis:post", - "archetypes.analysis:delete", -]; -export const analysisReadScopes = [ - "applications.analysis:get", - "archetypes.analysis:get", -]; +export const analysesReadScopes = ["applications.analyses:get"]; export const assessmentWriteScopes = [ "applications.assessments:put",