Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future enhancement - Clear all filters callback required when clearing filter state created from url query params #1667

Open
ibolton336 opened this issue Jan 19, 2024 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯

Comments

@ibolton336
Copy link
Member

Description

This issue tracks the need to expand the "clear all" filters functionality to all filterable tables (with initial values populated from url query params) within our application. The recent changes in PR addressed the issue of broken search strings when navigating from dependencies page and applied the "clear all" function to specific cases. However, there may be a future need to apply this functionality to new filterable tables & the desire is to make this seamless & as easy as possible.

Background

  • The current implementation in PR handles cases where initial filter values are parsed and loaded from the URL query parameters.
  • The challenge arises due to the use of the PF library component, which manages the chip state and the clear button state.
  • The toolbar exposes the clearAllFilters callback for special cases like the one we encountered.
  • Our goal is to integrate this solution more broadly and seamlessly. If nothing else, this issue documents this PF shortcoming for future reference.

Proposed Solution

  • Investigate the feasibility of integrating the clearAllFilters functionality into our custom filter toolbar component. There may be a better way to do this instead of repeating this code everywhere we need it. Maybe a hook?
  • Assess which tables currently lack this functionality and would benefit from it.
@ibolton336 ibolton336 added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ labels Jan 19, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jan 29, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. labels Jun 6, 2024
@sjd78 sjd78 moved this from 🆕 New to 🔖 Ready in Planning Jun 6, 2024
@konveyor-ci-bot
Copy link

This issue has been marked 'good first issue'
Please, make sure it aligns with the criteria found here

@Ytemiloluwa
Copy link

Hello @sjd78 @ibolton336 my name is Temiloluwa. I will like to take up this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
Status: 🔖 Ready
Development

No branches or pull requests

3 participants