fix: git attrs calculation #173
Conversation
Signed-off-by: tison <[email protected]>
| @@ -151,7 +153,7 @@ pub fn resolve_file_attrs( | |||
|
|
|||
| Ok::<_, Infallible>(Default::default()) | |||
| })?; | |||
| prev_commit = this_commit; | |||
| next_commit = this_commit; | |||
There was a problem hiding this comment.
This patch is a follow-up to #150 and GitoxideLabs/gitoxide#1395.
@Byron I'm figuring out how to walk the first commit tree. That said, the current logic iterate all the commits and calculate the changes between a next commit and a current commit. The iteration will exit on the very first (root) commit, then all the changes in the root commit won't be handled.
I'm not quite sure how to get a full change list (or just iterate all the files in the root commit). Investigating...
There was a problem hiding this comment.
The idea is to have an empty source tree to compare with if a commit has no parents.
There is an alternative API now, https://docs.rs/gix/latest/gix/struct.Repository.html#method.diff_tree_to_tree, which might make this more obvious and/or easier to use.
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
This closes #171