Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs more documentation regarding Modals #185

Open
echosalik opened this issue Aug 26, 2016 · 6 comments
Open

Needs more documentation regarding Modals #185

echosalik opened this issue Aug 26, 2016 · 6 comments

Comments

@echosalik
Copy link

There is little or no detail on how modal works. Please give more details regarding modals like a code sample etc. Not just HTML markup.

@webbiesdk
Copy link
Collaborator

2 things:

  • index.html works as the code sample. It showcases almost every single feature. Not just with the code-samples shown, but also the source-code of index.html itself. (And in the modal example, that includes how the callbacks work).
  • The best way to get more details on how the modals work, is to write it yourself. Anyone can send in a pull-request, and a lot of people have. Just the modal directive have 5 different authors according to git blame.

Remember, no-one is getting paid to do this.

@echosalik
Copy link
Author

Dude, if i was that good with angular I would have submitted a pull request. :P Plus thanks for the direction. I was using developer tools to view the HTML and wasn't able to find it.

@echosalik
Copy link
Author

@webbiesdk would you be abel to provide a modal example with controller? All i see is this line in ModalController scope.openModal = false; but I dont get it how to use it. Like where is openModal applied etc.

@echosalik
Copy link
Author

Ok, I got it to work. Which is kinda a long route to be honest. You need an extra element for this to work. As you have already labeled it as an enhancement, my suggestion for the enhancement is: Allow modals to be set without this extra element (trigger element).

@mushtaqak
Copy link

I agree with @webbiesdk that if we want more documentation then we should need to add some documentation ourselves, this way future developers won't have to waste a lot of times. 👍

@vikasraok
Copy link

@DragoTechInnovations put up your solution here maybe? I just went with the ui.bootstrap modal instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants