Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alias function #61

Open
fkautz opened this issue Aug 7, 2021 · 1 comment
Open

Remove alias function #61

fkautz opened this issue Aug 7, 2021 · 1 comment

Comments

@fkautz
Copy link
Collaborator

fkautz commented Aug 7, 2021

Now that we generate package imports automagically, the alias function is likely not necessary anymore. Would possibly be good to remove it.

@krisnova
Copy link
Owner

krisnova commented Aug 9, 2021

Right now we calculate the package alias types by hard coding a list of "known" types within each each package

I believe we can build these types in at compile time somehow (I am assuming similarly to how we use _embed.sh.

The other option would be to look up the package types at runtime.

Either way - we should be able to make the alias concern "full proof" so that we are not responsible for maintaining a hard-coded list of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants