Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll jump on thumbnail click #34

Open
chupakasmgn opened this issue Mar 28, 2017 · 8 comments
Open

Scroll jump on thumbnail click #34

chupakasmgn opened this issue Mar 28, 2017 · 8 comments

Comments

@chupakasmgn
Copy link

Mostly plugin works perfectly but some times then click on thumbnail it jump down scroll. How fix it?

@kthornbloom
Copy link
Owner

Hi, I'm not sure exactly what you mean. The whole page is scrolling down?

@chupakasmgn
Copy link
Author

chupakasmgn commented Mar 30, 2017 via email

@ats3v
Copy link

ats3v commented Apr 18, 2017

Hi,
We have exactly the same issue. What can we do? Thanks!

@kthornbloom
Copy link
Owner

Hey guys. I am having trouble replicating this bug. I'd be happy to look at it if someone can provide a simplified test where I can check out the code.

@ats3v
Copy link

ats3v commented Apr 18, 2017

Hey, thank you very much for your response. The problem does not happen every time, so it is definitely hard to reproduce. This is a link to our website (product details page):
https://fashionlime.bg/jeni/lqtno-sako-260
To reproduce the issue click to the next picture thumbnail (the second one for example). If you can't reproduce it from the first time try to refresh the page a couple of times. If you can't reproduce it again you can try to change the color of the product. This is the select list with the colors of the product:
https://drive.google.com/file/d/0B-zbpkUSOG-gOVVER21BaEdXbGM/view?usp=sharing
Try to change its value. When the user changing it from the java script code we do:
$('.sp-thumbs').find('a[href="' + picture.url + '"]').click();
Where the picture.url is the first picture from this newly selected color.
I use Chrome 57 on Mac OS and the issue reproduces one of every 5 times approximately when I browse among different products.
I will be happy to provide you any further information if needed. Thanks again!

@kthornbloom
Copy link
Owner

Thanks @goodcode. I was able to see the jump happening on your website once or twice. If it jumped to the top, I could understand, but since it jumps downward, I'm not sure what could cause that. There is no code in my plugin that scrolls the page.

I'm also not able to replicate it using my own demo files. Could there be some other plugin/code that might be affecting things? If you run smooth products by its self with just some filler content for height, do you still have the issue?

@chupakasmgn
Copy link
Author

Maybe some code in js of bootstrap framework affecting on this.

@ats3v
Copy link

ats3v commented Apr 19, 2017

@chupakasmgn are you using Bootstrap in your project as well? The other thing that can probably affect this is Rails turbolinks feature. But I tried to turn it off and the bug still persists. I don't think I use anything else specific that can affect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants