Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

presubmit build have one extra argument #71

Open
Jeffwan opened this issue May 14, 2020 · 1 comment
Open

presubmit build have one extra argument #71

Jeffwan opened this issue May 14, 2020 · 1 comment
Labels

Comments

@Jeffwan
Copy link
Member

Jeffwan commented May 14, 2020

/bin/bash -c /mnt/test-data-volume/kubeflow-xgboost-operator-presubmit-build-70-9aa764f-7905-1ef1/src/kubeflow/xgboost-operator//build_image.sh 

/mnt/test-data-volume/kubeflow-xgboost-operator-presubmit-build-70-9aa764f-7905-1ef1/src/kubeflow/xgboost-operator/Dockerfile 
gcr.io/kubeflow-ci/xgboost-operator 
v1.0

In build_image.sh scripts, we only consume two arguments.

DOCKERFILE=$1
CONTEXT_DIR=$(dirname "$DOCKERFILE")
IMAGE=$2

If we add extra argument, it will v1.0 will be assigned which may brings problems. I meet this problem working on #70

At the beginning, I use TIMEOUT=${3-:30m} then it grants v1.0 to timeout and fail the test.

I think we can either delete v1.0 tag, since build_image.sh generate dirty tags here

TAG=$(git describe --tags --always --dirty)

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.91

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant