Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart service missing namespace #102

Open
kelishia opened this issue Jan 30, 2025 · 0 comments
Open

Helm chart service missing namespace #102

kelishia opened this issue Jan 30, 2025 · 0 comments

Comments

@kelishia
Copy link

We're currently rendering out the Helm chart using a different mechanism than helm install. I've noticed that the Service template manifest does not have an explicit spec for namespace, like the other resources do. It would be useful to have that release namespace field for the service. It will also make it more consistent with the other Helm manifests in the repo. I'm happy to create a PR for this:

apiVersion: v1
kind: Service
metadata:
  namespace: {{ .Release.Namespace }}

Please let me know if you can see any reason why this shouldn't be in the config.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant