You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're currently rendering out the Helm chart using a different mechanism than helm install. I've noticed that the Service template manifest does not have an explicit spec for namespace, like the other resources do. It would be useful to have that release namespace field for the service. It will also make it more consistent with the other Helm manifests in the repo. I'm happy to create a PR for this:
apiVersion: v1
kind: Service
metadata:
namespace: {{ .Release.Namespace }}
Please let me know if you can see any reason why this shouldn't be in the config.
Thanks!
The text was updated successfully, but these errors were encountered:
We're currently rendering out the Helm chart using a different mechanism than
helm install
. I've noticed that the Service template manifest does not have an explicit spec for namespace, like the other resources do. It would be useful to have that release namespace field for the service. It will also make it more consistent with the other Helm manifests in the repo. I'm happy to create a PR for this:Please let me know if you can see any reason why this shouldn't be in the config.
Thanks!
The text was updated successfully, but these errors were encountered: