From 57c0a972b452982d9d6469e021ab7a59d6057baf Mon Sep 17 00:00:00 2001 From: Raunak Pradip Shah Date: Fri, 5 Jan 2024 18:14:35 -0800 Subject: [PATCH] Fix unit test --- pkg/validation-webhook/groupsnapshot_test.go | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/pkg/validation-webhook/groupsnapshot_test.go b/pkg/validation-webhook/groupsnapshot_test.go index 4dfc214c4..86e5189b8 100644 --- a/pkg/validation-webhook/groupsnapshot_test.go +++ b/pkg/validation-webhook/groupsnapshot_test.go @@ -248,11 +248,14 @@ func TestAdmitVolumeGroupSnapshotV1Alpha1(t *testing.T) { func TestAdmitVolumeGroupSnapshotContentV1Alpha1(t *testing.T) { volumeHandle := "volumeHandle1" - modifiedField := "modified-field" + modifiedField := &volumegroupsnapshotv1alpha1.GroupSnapshotHandles{ + VolumeGroupSnapshotHandle: "modifiedField", + } groupSnapshotHandle := "groupsnapshotHandle1" + volumeSnapshotHandles := []string{"volumeSnapshotHandle1", "volumeSnapshotHandle2"} groupSnapshotHandles := &volumegroupsnapshotv1alpha1.GroupSnapshotHandles{ - VolumeGroupSnapshotHandle: "volumeGroupSnapshotHandle1", - VolumeSnapshotHandles: []string{"volumeSnapshotHandle1", "volumeSnapshotHandle2"}, + VolumeGroupSnapshotHandle: groupSnapshotHandle, + VolumeSnapshotHandles: volumeSnapshotHandles, } volumeGroupSnapshotClassName := "volume-snapshot-class-1" validContent := &volumegroupsnapshotv1alpha1.VolumeGroupSnapshotContent{ @@ -321,7 +324,7 @@ func TestAdmitVolumeGroupSnapshotContentV1Alpha1(t *testing.T) { groupSnapContent: &volumegroupsnapshotv1alpha1.VolumeGroupSnapshotContent{ Spec: volumegroupsnapshotv1alpha1.VolumeGroupSnapshotContentSpec{ Source: volumegroupsnapshotv1alpha1.VolumeGroupSnapshotContentSource{ - VolumeGroupSnapshotHandle: &modifiedField, + GroupSnapshotHandles: modifiedField, }, VolumeGroupSnapshotRef: core_v1.ObjectReference{ Name: "snapshot-ref", @@ -332,17 +335,20 @@ func TestAdmitVolumeGroupSnapshotContentV1Alpha1(t *testing.T) { oldGroupSnapContent: validContent, shouldAdmit: false, operation: v1.Update, - msg: fmt.Sprintf("Spec.Source.VolumeGroupSnapshotHandle is immutable but was changed from %s to %s", groupSnapshotHandle, modifiedField), + msg: fmt.Sprintf("Spec.Source.GroupSnapshotHandles is immutable but was changed from %s to %s", groupSnapshotHandle, modifiedField), }, { name: "Update: old is valid and new is valid but modifies immutable ref", groupSnapContent: &volumegroupsnapshotv1alpha1.VolumeGroupSnapshotContent{ Spec: volumegroupsnapshotv1alpha1.VolumeGroupSnapshotContentSpec{ Source: volumegroupsnapshotv1alpha1.VolumeGroupSnapshotContentSource{ - VolumeGroupSnapshotHandle: &groupSnapshotHandle, + GroupSnapshotHandles: &volumegroupsnapshotv1alpha1.GroupSnapshotHandles{ + VolumeGroupSnapshotHandle: groupSnapshotHandle, + VolumeSnapshotHandles: volumeSnapshotHandles, + }, }, VolumeGroupSnapshotRef: core_v1.ObjectReference{ - Name: modifiedField, + Name: "modifiedField", Namespace: "default-ns", }, },