Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final Backup Missing CSI Driver Tag #57

Open
gomesjason opened this issue Oct 5, 2023 · 2 comments
Open

Final Backup Missing CSI Driver Tag #57

gomesjason opened this issue Oct 5, 2023 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@gomesjason
Copy link
Contributor

gomesjason commented Oct 5, 2023 •
edited
Loading

/kind bug

What happened?
Final backups don't contain the fsx.openzfs.csi.aws.com/cluster key denoting it was created from the CSI driver

What you expected to happen?
When SkipFinalBackup is set to false, the CSI driver should append its custom tag to the deletion parameter FinalBackupTags, similarly to how we do it during create.

How to reproduce it (as minimally and precisely as possible)?
Dynamically create a filesystem, and set SkipFinalBackupOnDeletion to false. Then delete the filesystem, and check the tags.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 5, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2024
@gomesjason
Copy link
Contributor Author

gomesjason commented Jan 30, 2024 •
edited
Loading

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 30, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 30, 2024
@gomesjason gomesjason removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k8s-ci-robot @k8s-triage-robot @gomesjason