Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IngressClass objects #117

Open
levikobi opened this issue Jan 3, 2024 · 20 comments
Open

Add support for IngressClass objects #117

levikobi opened this issue Jan 3, 2024 · 20 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@levikobi
Copy link
Member

levikobi commented Jan 3, 2024

What would you like to be added:
Add support for reading and taking into account IngressClass objects.

Why this is needed:
If users do not specify ingressClassName, we need to understand the default IngressClass that should be used for the conversion.

@levikobi levikobi added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 3, 2024
@levikobi
Copy link
Member Author

levikobi commented Jan 4, 2024

/help

@k8s-ci-robot
Copy link
Contributor

@levikobi:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 4, 2024
@mlavacca
Copy link
Member

mlavacca commented Feb 1, 2024

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@mlavacca:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 1, 2024
@akagami-harsh
Copy link

/assign

Varun1300211 added a commit to Varun1300211/ingress2gateway that referenced this issue Feb 13, 2024
Varun1300211 added a commit to Varun1300211/ingress2gateway that referenced this issue Feb 13, 2024
@Varun1300211
Copy link

I have created a PR for the same. Kindly review it.

Varun1300211 added a commit to Varun1300211/ingress2gateway that referenced this issue Feb 13, 2024
@levikobi
Copy link
Member Author

I just now noticed that @akagami-harsh asked to work on this issue first.
@akagami-harsh are you still interested in working on it?

@akagami-harsh
Copy link

@levikobi yes i am interested. i was busy with other things, but now i am free

@akagami-harsh
Copy link

Since there's already an open PR for this issue, should I create a new one?

@LiorLieberman
Copy link
Member

LiorLieberman commented Feb 14, 2024

Hi @akagami-harsh, no.
There is already a PR @Varun1300211 opened.

Please check out other issues like #81 if you are still up for contributing. We would love to have you.

@Varun1300211 While we appreciate you quickly made a PR and sent for review, next time, please kindly try to confirm with the current assignee if he is working on it before proceeding with a PR

@Varun1300211
Copy link

Apologies @akagami-harsh, I am still very new to the open source. Never seen you were already assigned to it before. Hope you understand.

Sure @LiorLieberman will keep it in mind from the next time onwards.

@akagami-harsh
Copy link

No worries at all, @Varun1300211! It happens, and I appreciate you being open to the feedback. Thanks for letting me know, @LiorLieberman . I'll take a look at issue #81.

@ipsum-0320
Copy link

hi @akagami-harsh, are you still working on it, I would like to give it a try. 😊 /assign

@mlavacca
Copy link
Member

mlavacca commented Apr 2, 2024

@ipsum-0320, please notice @Varun1300211 is already assigned to this issue.

@Varun1300211, are you still working on it?

@ipsum-0320
Copy link

@ipsum-0320, please notice @Varun1300211 is already assigned to this issue.

@Varun1300211, are you still working on it?

okok, I will wait until @Varun1300211 replies before taking the next step 😊

@VasuDevrani
Copy link

/assign

@VasuDevrani
Copy link

VasuDevrani commented May 13, 2024

@levikobi @LiorLieberman
If neither the ingressClassName field nor the kubernetes.io/ingress.class annotation is set on the Ingress, the tool skips processing that Ingress, resulting in no Gateway API resources?

@levikobi
Copy link
Member Author

@levikobi @LiorLieberman If neither the ingressClassName field nor the kubernetes.io/ingress.class annotation is set on the Ingress, the tool skips processing that Ingress, resulting in no Gateway API resources?

At the time I opened this issue this was correct @VasuDevrani, I think this still holds true though.
The purpose of this issue is to add support for reading the ingressClasses, one of them should be the default. Then we will be able to convert ingresses without the field or annotation being specified

@mlavacca
Copy link
Member

Hi @VasuDevrani, any news on this issue? If you need some help, please let us know :)

@TusharMohapatra07
Copy link

hey @mlavacca is this issue still open to contributions ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants