Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require "name" in "kind delete cluster" cli command #3829

Open
abuchanan-airbyte opened this issue Dec 20, 2024 · 1 comment
Open

Require "name" in "kind delete cluster" cli command #3829

abuchanan-airbyte opened this issue Dec 20, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@abuchanan-airbyte
Copy link

What would you like to be added:

I'd like to require the "name" option in the kind delete cluster command.

Why is this needed:

I accidentally deleted my "kind" cluster when I had intended to delete my "foo" cluster. This happened because I assumed kind would delete the "current" cluster instead of the "cluster".

I realize now that the kind command does not actually have a "current" context, but since kind create cluster updates the current kube context, where I think work for awhile with kubectl, I was in that mindset.

But aside from that, for something destruction like delete, I think it's better to be explicit about what you want to delete.

One reason not to do this could be backwards compat – users that have scripts that depend on the current behavior would have failing scripts after upgrading kind. I'm not sure how sensitive this project is to CLI compat.

Thanks!

@abuchanan-airbyte abuchanan-airbyte added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 20, 2024
@aojea
Copy link
Contributor

aojea commented Dec 20, 2024

I'm not sure how sensitive this project is to CLI compat.

Very very sensitive, one of the biggest strength is the stability ... Does not mean if something is reasonable it can be considered, but this seems a fat fingers problem that can be solved by end user by applying convention to not mix default and explicit values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants