Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubectl-graph plugin to krew #503

Closed
ishantanu opened this issue Feb 20, 2020 · 11 comments
Closed

Add kubectl-graph plugin to krew #503

ishantanu opened this issue Feb 20, 2020 · 11 comments
Assignees

Comments

@ishantanu
Copy link

Hi,

As discussed in awesome-kubectl-plugins sync issue, opening an issue to add kubectl-graph to krew index.

See the reference awesome-kubectl-plugin repository's commit which added this plugin to the list.

@corneliusweig
Copy link
Contributor

Hey @ishantanu, thanks for bringing this up. I think it's great that you just opened this issue and didn't create a PR. This is exactly how it should work 👍

@steveteuber what is your opinion about bringing kubectl-graph into krew? It doesn't take much, you just have to write a manifest and update that with your most recent version if you do a release. Would you be open to maintain this?


I haven't tried the plugin so I don't know for sure what it does. It seems to be a good idea, to print a dependency graph though. My major problem right now is that it is hardly documented. Some documentation and maybe also an example on the project landing page would be great. Otherwise, users won't even know what this is all about.

Regarding the plugin name: I suspect that graph is too generic. Can you come up with a more specific name? Also, it would be nice to know how it relates to kubectl tree which is already in krew-index.

@steveteuber
Copy link
Contributor

Hi @corneliusweig,

I've created the repository exactly one week ago. And yes, I would like to make this plugin available via krew. But first I need to create a fully working kubectl plugin. When everything works as expected, then I create a first release which can be added to the krew-index.

Regarding the plugin name, the generic name is intended to be universal.
The task of the plugin is to get a dependency graph in different output formats, which can be used to visualize Kubernetes resources and relationships in Graphviz or Neo4j.

Could you please assign this issue to me?

@corneliusweig
Copy link
Contributor

@steveteuber

And yes, I would like to make this plugin available via krew

That's great. Looking forward to your submission!

Regarding the plugin name, the generic name is intended to be universal.

I see. For krew we strive to avoid generic names though. It is much easier for users to discover your plugin if the name is more descriptive. Let's discuss this when you submit your plugin. However be prepared that there's a high chance we will not accept the generic name. As far as I understand, resource-graph would be a better choice. WDYT?

@ahmetb
Copy link
Member

ahmetb commented Feb 23, 2020

I am actually ok with “graph” name. You probably only can do a graph of “resource”s anyway so it’s sort of redundant. Similarly, “tree” could be “resource-tree” but to a good degree the implicit meaning can be easily understood.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2020
@satishweb
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2020
@ahmetb
Copy link
Member

ahmetb commented May 28, 2020

@steveteuber let us know when you make progress and you can integrate with release automation we have https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/ to update this repo when you have a new version.

/hold
/lifecycle frozen

@ahmetb
Copy link
Member

ahmetb commented Aug 5, 2020

@steveteuber pinging for interest. happy to accept this as a plugin.

@steveteuber
Copy link
Contributor

@ishantanu this issue can be closed. The plugin is now listed in the krew-index:

$ kubectl krew update
Updated the local copy of plugin index.
  New plugins available:
    * graph

@ahmetb
Copy link
Member

ahmetb commented Aug 25, 2020

/close

@k8s-ci-robot
Copy link
Contributor

@ahmetb: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants