Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EOL Fedora 37/38 #11524

Closed
VannTen opened this issue Sep 12, 2024 · 11 comments · Fixed by occase/kubespray#1 or #11600
Closed

Remove EOL Fedora 37/38 #11524

VannTen opened this issue Sep 12, 2024 · 11 comments · Fixed by occase/kubespray#1 or #11600
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@VannTen
Copy link
Contributor

VannTen commented Sep 12, 2024

What would you like to be added

Both Fedora 37 and 38 are EOL (https://docs.fedoraproject.org/en-US/releases/eol/#_unsupported_fedora_linux_releases)
We should remove them.

We can replace them by 39 and 40, that could be done at the same time or in a follow-up (or even before, does not really matter)

This would need:

  1. remove them from CI, testcases, etc
  2. remove from documentation
  3. remove special handling in kubespray roles
  4. cleanup/refactor following point 3 => this steps is not absolutely necessary, but at the very least cleanup opportunities should be marked with TODO items.

Why is this needed

Less code, less bugs, happy maintainers.

@VannTen VannTen added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 12, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Sep 12, 2024

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@VannTen:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 12, 2024
@yankay
Copy link
Member

yankay commented Sep 13, 2024

The images need to be built and pushed to quay so the CI can run .
I'll help do this when someone is working for the PR.

@VannTen
Copy link
Contributor Author

VannTen commented Sep 15, 2024 via email

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 15, 2024
@tico88612 tico88612 mentioned this issue Sep 17, 2024
6 tasks
@tico88612
Copy link
Member

Support for Fedora 39/40; I opened a separate issue #11548.

@occase
Copy link

occase commented Sep 30, 2024

/assign

occase added a commit to occase/kubespray that referenced this issue Sep 30, 2024
occase added a commit to occase/kubespray that referenced this issue Sep 30, 2024
@tico88612
Copy link
Member

@occase Are you still working on this?

@occase
Copy link

occase commented Oct 1, 2024

@tico88612 I thought I had fixed it. Still new at this..
Do I need to do anything else?
I just deleted my branch bc it looks like it says it's fixed.

@tico88612
Copy link
Member

@occase you should open the PR to this repo, not on your fork repo.

@tico88612
Copy link
Member

In addition to changing README.md, this PR also needs to delete files with Fedora 37/38.

@tico88612
Copy link
Member

/unassign @occase
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
5 participants