Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameters to hcloud-cloud-controller-manager #11934

Open
madoe opened this issue Jan 28, 2025 · 0 comments
Open

Wrong parameters to hcloud-cloud-controller-manager #11934

madoe opened this issue Jan 28, 2025 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@madoe
Copy link

madoe commented Jan 28, 2025

What happened?

I just noticed that the start parameters to hcloud-cloud-controller-manager in external-hcloud-cloud-controller-manager-ds-with-networks.yml.j2 and external-hcloud-cloud-controller-manager-ds.yml.j2 differs from the parameters used in the original project.

Hcloud CCM can be deployed either as DaemonSet or as Deployment. --leader-elect=false must only be used in a deployment with 1 replica. In a DaemonSet or Deployment with more than 1 replica --leader-elect=false must not be used.

Also the use of newly introduced parameters --route-reconciliation-period=30s and --webhook-secure-port=0 should be considered. See comment in https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/main/chart/values.yaml

What did you expect to happen?

Correct parameters should be used

How can we reproduce it (as minimally and precisely as possible)?

n/a

OS

n/a

Version of Ansible

n/a

Version of Python

n/a

Version of Kubespray (commit)

2.27.0

Network plugin used

calico

Full inventory with variables

n/a

Command used to invoke ansible

n/a

Output of ansible run

n/a

Anything else we need to know

No response

@madoe madoe added the kind/bug Categorizes issue or PR as related to a bug. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant