Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrapper for ProvisioningRequestConfig to util/testing package #3472

Open
PBundyra opened this issue Nov 6, 2024 · 5 comments · May be fixed by #3560
Open

Add wrapper for ProvisioningRequestConfig to util/testing package #3472

PBundyra opened this issue Nov 6, 2024 · 5 comments · May be fixed by #3560
Assignees
@TusharMohapatra07
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@PBundyra
Copy link
Contributor

PBundyra commented Nov 6, 2024 •
edited
Loading

What would you like to be added:
Wrapper for ProvisioningRequestConfig similarly to e.g. PriorityClassWrapper. Besides fundamental methods to create wrapper and actual object we also need methods to set:

  • .spec.provisioningClassName
  • .spec.parameters
  • .spec.managedResources
  • .spec.retryStrategy
  • .spec.retryStrategy.backoffLimitCount
  • .spec.retryStrategy.backoffBaseSeconds
  • .spec.retryStrategy.backoffMaxSeconds

Wrapper should be used in all test files where ProvisioningRequestConfig is used, including:

  • pkg/controller/admissionchecks/provisioning/admissioncheck_reconciler_test.go
  • pkg/controller/admissionchecks/provisioning/controller_test.go
  • pkg/util/admissioncheck/admissioncheck_test.go
  • test/integration/controller/admissionchecks/provisioning/provisioning_test.go

Why is this needed:
Improve code quality

Completion requirements:
@PBundyra PBundyra added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 6, 2024
@PBundyra
Copy link
Contributor Author

PBundyra commented Nov 6, 2024

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 6, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 6, 2024

cc @mbobrovskyi @vladikkuzn @mszadkow

@TusharMohapatra07
Copy link
Contributor

Can i work on this issue ?

@mimowo
Copy link
Contributor

mimowo commented Nov 6, 2024

Sure, please use '/assign' in that case

@TusharMohapatra07
Copy link
Contributor

/assign

@TusharMohapatra07 TusharMohapatra07 linked a pull request Nov 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TusharMohapatra07 TusharMohapatra07

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add wrapper for ProvisioningRequestConfig to util/testing package[WIP] TusharMohapatra07/kueue
4 participants
@mimowo @k8s-ci-robot @PBundyra @TusharMohapatra07