Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imprecise log line: LocalQueue for workload didn't exist #3527

Open
gabesaba opened this issue Nov 13, 2024 · 0 comments
Open

Imprecise log line: LocalQueue for workload didn't exist #3527

gabesaba opened this issue Nov 13, 2024 · 0 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@gabesaba
Copy link
Contributor

What would you like to be cleaned:
When AddOrUpdateWorkloadWithoutLock returns false, there are several lines which may log that a LocalQueue does not exist

e.g.

if !r.queues.AddOrUpdateWorkloadWithoutLock(wlCopy) {
log.V(2).Info("LocalQueue for workload didn't exist or not active; ignored for now")
}

Unfortunately, this function can also return false when the ClusterQueue is not located

kueue/pkg/queue/manager.go

Lines 336 to 339 in 2c8e7da

cq := m.hm.ClusterQueues[q.ClusterQueue]
if cq == nil {
return false
}

We should differentiate whether the ClusterQueue or LocalQueue is missing in the log lines which depend on (directly or indirectly) the return value of this function.

Why is this needed:
To assist with future debugging, and to make our logging more precise.

@gabesaba gabesaba added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

1 participant