Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the reason for Evicted condition for deactivated workloads: WorkloadInactive -> Deactivated #3530

Open
mimowo opened this issue Nov 14, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Nov 14, 2024

What would you like to be added:

Rename the reason InactiveWorkload -> Deactivated.

Here is the definition.

Deprecate but continue supporting the old one for backwards- compatibility. We need a couple of releases or v1beta2 to drop the old one.

Why is this needed:

  • the "Workload" is redundant. Other reasons don't contain it, see here.
  • this is a reason for Evicted=True, so Deactivated reads better
  • by analogy to Reactivated
@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 14, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Nov 14, 2024

cc @PBundyra @mbobrovskyi @tenzen-y

@PBundyra
Copy link
Contributor

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants