Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy to describe the preempting workload #4038

Open
2 tasks
avrittrohwer opened this issue Jan 22, 2025 · 2 comments
Open
2 tasks

Make it easy to describe the preempting workload #4038

avrittrohwer opened this issue Jan 22, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@avrittrohwer
Copy link
Contributor

avrittrohwer commented Jan 22, 2025

What would you like to be added:

Make it easy to kubectl describe the workload that evicted another workload.

Why is this needed:

Kueue Workloads have events like kueue-admission Preempted to accommodate a workload (UID: <UID>) due to fair sharing within the cohort

As far as I can tell kubectl --selector field only supports filtering on values in the object .metadata.labels. The Workload UID is in the .metadata.UID field which can not be filtered on by kubectl --selector. For clusters with few workloads grepping on kubectl get workloads -A would work but does not scale for clusters with thousands of workloads.

Completion requirements:

Make it easy to kubectl describe the Workload that preempted another workload. Simple solution: add the Workload UID to the Workload labels.

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • [ x] Docs update -> add docs on how to get details of preempting workload.

The artifacts should be linked in subsequent comments.

@avrittrohwer avrittrohwer added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 22, 2025
@avrittrohwer avrittrohwer changed the title Make it easy to find the preempting workload Make it easy to describe the preempting workload Jan 22, 2025
@kannon92
Copy link
Contributor

Have you looked at kueuectrl? maybe the UX would be better using the CLI?

@mimowo
Copy link
Contributor

mimowo commented Jan 23, 2025

I don't remember if kueuectl would allow it, probably not. However, in any case as an external binary the only way to find the preempting workload by UID would be to list all workloads first, which is not scalable indeed.

I like the idea of adding the UID as a label. cc @tenzen-y WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants