Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create structs for ui objects in kueue-viz instead of ad-hoc objects #4053

Open
akram opened this issue Jan 24, 2025 · 1 comment
Open

Create structs for ui objects in kueue-viz instead of ad-hoc objects #4053

akram opened this issue Jan 24, 2025 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/dashboard Denotes a PR that is related to the built-in dashboard

Comments

@akram
Copy link
Contributor

akram commented Jan 24, 2025

What would you like to be cleaned:
In most backend functions, ad-hoc objects are created to convey data from the kube api to the websocket layer. This was done for several reasons:

  • forwarding directly the kubernetes objects would have been too heavy as most of the fields are not used on the ui side
  • the dashboard is, currently, a read-only view of aggregated data from the kubernetes api, so, it would not have been necessary to convey kubernetes data back for saving (for example)
  • the sake of quick development

Why is this needed:
It could be interesting to have dedicated objects for this usage for better debuggability, especially on the client side, and to ensure data consistency.

As a first pass, we can create structs manually based on the existing ad-hoc objects. But, if we can find a way to generate them later it could be more efficient.

@akram akram added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 24, 2025
@akram akram changed the title Create structs for ui objects instead of ad-hoc objects Create structs for ui objects in kueue-viz instead of ad-hoc objects Jan 24, 2025
@akram
Copy link
Contributor Author

akram commented Jan 24, 2025

/kind dashboard

@k8s-ci-robot k8s-ci-robot added the kind/dashboard Denotes a PR that is related to the built-in dashboard label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/dashboard Denotes a PR that is related to the built-in dashboard
Projects
None yet
Development

No branches or pull requests

2 participants