Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention of lws statefulsets #236

Open
liurupeng opened this issue Oct 23, 2024 · 2 comments
Open

Naming convention of lws statefulsets #236

liurupeng opened this issue Oct 23, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@liurupeng
Copy link
Collaborator

liurupeng commented Oct 23, 2024

What happened:
If a user deployed multiple lws objects in the same cluster with names like: lws; lws-1; lws-2; then the "lws" object will create sts lws-1 as the worker sts; but "lws-1" lws object will create sts lws-1 as the leader sts.
What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

  1. Create a LWS object with name "lws" with size 4 and replicas 3;
  2. Create a LWS object with name "lws-1 with size 4 and replicas 3"
  3. Verify that pods count is incorrect

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • LWS version (use git describe --tags --dirty --always):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@liurupeng liurupeng added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2024
@liurupeng liurupeng changed the title Name convention of lws statefulsets Naming convention of lws statefulsets Oct 23, 2024
@kannon92
Copy link
Contributor

What is your suggestion for this issue?

@liurupeng
Copy link
Collaborator Author

I think this would be tricky to fix, I haven't thought through it yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants