Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LimitRange.Spec.Limits omitempty #78

Open
colinhoglund opened this issue Sep 21, 2024 · 0 comments
Open

LimitRange.Spec.Limits omitempty #78

colinhoglund opened this issue Sep 21, 2024 · 0 comments

Comments

@colinhoglund
Copy link

It seems like the following field should probably omitempty, so that json.Unmarshal of an empty LimitRange doesn't zero out non-empty Limits.

api/core/v1/types.go

Line 7010 in 71385f0

Limits []LimitRangeItem `json:"limits" protobuf:"bytes,1,rep,name=limits"`

Is there any reason this is not omitempty? If not, does it make sense to open a PR to change this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinhoglund