From 4b306b506e68a10f8ac33c7070d03c54199bfdd0 Mon Sep 17 00:00:00 2001 From: sunnylovestiramisu Date: Tue, 7 Jan 2025 23:12:02 +0000 Subject: [PATCH] Update Release Signoff Checklist for KEP-3751 before GA --- keps/prod-readiness/sig-storage/3751.yaml | 2 ++ .../3751-volume-attributes-class/README.md | 15 ++++++--------- .../3751-volume-attributes-class/kep.yaml | 10 +++++----- 3 files changed, 13 insertions(+), 14 deletions(-) diff --git a/keps/prod-readiness/sig-storage/3751.yaml b/keps/prod-readiness/sig-storage/3751.yaml index 46671672252..d2b623f6d3b 100644 --- a/keps/prod-readiness/sig-storage/3751.yaml +++ b/keps/prod-readiness/sig-storage/3751.yaml @@ -6,3 +6,5 @@ alpha: approver: "@johnbelamaric" beta: approver: "@johnbelamaric" +stable: + approver: "@johnbelamaric" diff --git a/keps/sig-storage/3751-volume-attributes-class/README.md b/keps/sig-storage/3751-volume-attributes-class/README.md index 299e24fe3ba..eb0d98cf12b 100644 --- a/keps/sig-storage/3751-volume-attributes-class/README.md +++ b/keps/sig-storage/3751-volume-attributes-class/README.md @@ -82,15 +82,15 @@ Items marked with (R) are required *prior to targeting to a milestone / release*. - [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR) -- [ ] (R) KEP approvers have approved the KEP status as `implementable` +- [X] (R) KEP approvers have approved the KEP status as `implementable` - [X] (R) Design details are appropriately documented -- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors) - - [ ] e2e Tests for all Beta API Operations (endpoints) - - [ ] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) +- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors) + - [X] e2e Tests for all Beta API Operations (endpoints) - [dashboard](https://testgrid.k8s.io/sig-storage-kubernetes#kind-storage-alpha-beta-features&include-filter-by-regex=%5BFeature%3AVolumeAttributesClass%5D&include-filter-by-regex=%5BFeature%3AVolumeAttributesClass%5D&include-filter-by-regex=%5C%5BFeature%3AVolumeAttributesClass%5C%5D) + - [X] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) - [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free - [ ] (R) Graduation criteria is in place - [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) -- [ ] (R) Production readiness review completed +- [X] (R) Production readiness review completed - [ ] (R) Production readiness review approved - [X] "Implementation History" section is up-to-date for milestone - [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io] @@ -694,10 +694,7 @@ VolumeAttributesClass parameters can be considered as best-effort parameters, th * Basic unit tests for performance and quota system. * API conformance tests -* E2E tests with happy tests in the [K8s storage framework](https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/testsuites) for different drivers testing -* E2E tests using mock driver to cause failure on create, update and recovering cases - * [K8s storage framework](https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/testsuites) - * [csi-tes](https://github.com/kubernetes-csi/csi-test) +* E2E tests: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/volumeattributesclass.go * Test coverage of quota usage with ResourceQuota and LimitRange * Measure latency impact to CreateVolume during beta and provide feedback to operators * Upgrade and rollback test when the feature gate changes to beta diff --git a/keps/sig-storage/3751-volume-attributes-class/kep.yaml b/keps/sig-storage/3751-volume-attributes-class/kep.yaml index 59e282c1713..b23f7c6a3c4 100644 --- a/keps/sig-storage/3751-volume-attributes-class/kep.yaml +++ b/keps/sig-storage/3751-volume-attributes-class/kep.yaml @@ -1,4 +1,4 @@ -title: Kubernetes Volume Provisioned IO +title: Kubernetes VolumeAttributesClass and ModifyVolume kep-number: 3751 authors: - "@mattcarry" @@ -6,7 +6,7 @@ authors: owning-sig: sig-storage participating-sigs: status: implementable -creation-date: 2023-01-24 +creation-date: 2024-01-22 reviewers: - "@msau42" - "@gnufied" @@ -18,18 +18,18 @@ see-also: replaces: # The target maturity stage in the current dev cycle for this KEP. -stage: beta +stage: stable # The most recent milestone for which work toward delivery of this KEP has been # done. This can be the current (upcoming) milestone, if it is being actively # worked on. -latest-milestone: "1.31" +latest-milestone: "1.33" # The milestone at which this feature was, or is targeted to be, at each stage. milestone: alpha: "v1.29" beta: "v1.31" - stable: + stable: "v1.33" # The following PRR answers are required at alpha release # List the feature gate name and the components for which it must be enabled