AddDirRecursive is broken on with go1.20

[dprotaso]

https://pkg.go.dev/k8s.io/gengo/parser#Builder.AddDirRecursive doesn't work if a path doesn't contain any go code. Prior go1.19 returned NoGoError which was handled here. Now it returns a different error breaking the parser.

See upstream issue: golang/go#58903

Workaround is to create an empty go file - ie. doc.go at every intermediate level. Maybe gengo parser can just handle the new error type.

[aojea]

/cc @thockin

[dprotaso]

I didn't really understand the response from the go team - it seems counter intuitive so I'm poking upstream.

[dprotaso]

Ok - it seems like the better option would be to use context.ImportDir vs Import

https://pkg.go.dev/go/build#Context.ImportDir - it will return https://pkg.go.dev/go/build#NoGoError if there is no go present

see the upstream issue for the description

[thockin]

I have a branch with MASSSSSSSIVE overhaul to gengo (i.e. gengo/v2) coming. I have to look at this new one, but I won't have time today probably. Please hold off on major major rework until I can catch up?

…

On Tue, Mar 7, 2023 at 7:17 AM Dave Protasowski ***@***.***> wrote: Ok - it seems like the better option would be to use context.ImportDir vs Import https://pkg.go.dev/go/build#Context.ImportDir - it will return https://pkg.go.dev/go/build#NoGoError if there is no go present — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[thockin]

Cool - this explains a weird behavior I saw just this weekend :)

My branch (hopefully to become gengo/v2) totally overhauls this path (to use packages.Load), so it's all moot eventually

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[thockin]

I'm still working on it, but very slowly. Is there a specific use-case that is broken right now?

[dprotaso]

This broke some crd to docs tools but there's a work around - add an empty go file to the dirs with no code

[thockin]

OK. I'm keeping this in my radar, but the overhaul is not imminent. If there's an easy fix, I am open to it.

…

On Wed, Jun 7, 2023 at 12:03 PM Dave Protasowski ***@***.***> wrote: This broke some crd to docs tools but there's a work around - add an empty go file to the dirs with no code — Reply to this email directly, view it on GitHub <#241 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKWAVDFOEGIE4W3L4YVFULXKDGBVANCNFSM6AAAAAAVRVVNTM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dprotaso]

If there's an easy fix, I am open to it.

Switch to ImportDir

#241 (comment)

[thockin]

If it is a drop-in replacement, I'd be OK with that.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[thockin]

Will be fixed in v2 (#259)

[dprotaso]

Woot thanks!

…

On Sat, Jan 27, 2024 at 23:31 Tim Hockin ***@***.***> wrote: Will be fixed in v2 (#259 <#259>) — Reply to this email directly, view it on GitHub <#241 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAERAQQOJZJZGWEMHVO7PTYQXIBPAVCNFSM6AAAAAAVRVVNTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGQ2DKMJYHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>