Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of network errors/timeouts #56

Open
f1ames opened this issue Nov 24, 2023 · 1 comment
Open

Better handling of network errors/timeouts #56

f1ames opened this issue Nov 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@f1ames
Copy link
Contributor

f1ames commented Nov 24, 2023

While testing the extension I stumbled upon few cases where there were some minor issues due to connectivity problems:

  1. There is a "blinking" of local policy sometimes when changing monokle.project (when fetching new policy takes longer).
  2. Occasional Monokle: fetchPolicyFiles TypeError: Cannot read properties of null (reading 'accessToken') error (which causes issues with policy sync for a single sync, usually fixed on next sync).
  3. Occasional Failed to parse '/home/kkrzton/Workspace/kubeshop/monokle-vsc/.monokle/ec5a1a57115b2b8cf9eeee71feafcb42.validation.json' error - looks like it's related to API timing out and I think extension removes policy file in such cases as outdated (but needs further investigation).

All above are related to connectivity problems and how does are handled. It doesn't cause any major issues with the extension running but there is a place for improvement.

@f1ames f1ames added the enhancement New feature or request label Nov 24, 2023
@f1ames
Copy link
Contributor Author

f1ames commented Nov 30, 2023

Let's also revisit catch-all handler for TypeErrors added in #61 as described in #61 (comment).

@f1ames f1ames mentioned this issue Nov 30, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant