Support for loadBlancerClass

[itmwiw]

What happened:
I have a Baremetal Host cluster with MetalLB installed in it, a Kubevirt Guest cluster, and I rely on kccm for LBs creation. Everything works fine, and whenever I create a service of type LoadBalancer in the Guest cluster, an equivalent sevice is created in the Host cluster to proxy the incoming requests. However when I create a LoadBlancer service in the Guest cluster and specify the loadBalancerClass property in the spec section, no service in created in the Host cluster and the service in the Guest cluster remains in 'pending' state.
Is the loadBalancerClass something kccm is aware of?

What you expected to happen:
The service is created in the host cluster with the correct loadBalancerClass.

How to reproduce it (as minimally and precisely as possible):
Create a Loadbalancer service type in the Guest Cluster.

Additional context:
MetalLb has also implemented the loadBalancerClass concept as described here

Environment:

• KubeVirt version (use virtctl version): N/A
• Kubernetes version (use kubectl version): N/A
• VM or VMI specifications: N/A
• Cloud provider or hardware configuration: N/A
• OS (e.g. from /etc/os-release): N/A
• Kernel (e.g. uname -a): N/A
• Install tools: N/A
• Others: N/A

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[kubevirt-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

[LKummer]

I bumped into this as well and want to implement this feature.

However, it seems unsafe to allow tenant clusters to use any loadBalancerClass.
How about we add an option to cloud-config named allowedLoadBalancerClasses containing a list of allowed load balancer classes? When allowedLoadBalancerClasses is omitted we can keep the existing behavior of ignoring loadBalancerClass.

[kubevirt-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

[kubevirt-bot]

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.