Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override firmware uuid while restoring a VM and VMI #327

Open
30787 opened this issue Feb 27, 2025 · 2 comments
Open

Ability to override firmware uuid while restoring a VM and VMI #327

30787 opened this issue Feb 27, 2025 · 2 comments

Comments

@30787
Copy link

30787 commented Feb 27, 2025

Is your feature request related to a problem? Please describe:
When a virtual machine is restored to an alternate namespace, the virtual machine is restored with the same firmware uuid as the original virtual machine if the vm spec had firmware uuid specified. This could result in fimrware uuid address conflict if the original virtual machine is still running in the original namespace.

Describe the solution you'd like:
Provide functionality to blank out or create new firmware uuid in vm and vmi spec based on label or annotation in velero restore job.

Describe alternatives you've considered:
None

Additional context:
Add any other context or screenshots about the feature request here.

@alromeros
Copy link
Contributor

alromeros commented Mar 3, 2025

Hi @30787, thanks for the proposal! This was already addressed in #317, which includes a label that allows overriding the firmware UUID for all restored VM/VMIs and creates a new one. Does this work for you? You should be able to test this in the latest plugin release.

@30787
Copy link
Author

30787 commented Mar 3, 2025

Thanks @alromeros. Does it mean that bios uuid from vm spec and standalone vmi is restored from backup copy by default and can be renewed with a new one using the label velero.kubevirt.io/generate-new-firmware-uuid in the velero restore job. For VMI owned by VM(if bios/firmware uuid is not specified in VM spec) bios/firmware uuid is always renwed by default right since VMI is not restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants