Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rehearse: enable auto rehearsal of specific jobs with annotation #3805

Open
dhiller opened this issue Dec 5, 2024 · 2 comments
Open

rehearse: enable auto rehearsal of specific jobs with annotation #3805

dhiller opened this issue Dec 5, 2024 · 2 comments
Labels
area/automation Issues and PRs concerning automation, i.e. KubeVirt job updates, KubeVirtCI bumps etc. kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Indicate that the issue or PR is a lower priority and can be worked on in the future

Comments

@dhiller
Copy link
Contributor

dhiller commented Dec 5, 2024

Having the new skip-review label enables us to get PRs merged automatically, however, to improve this by avoiding possibly breaking image changes we could add an annotation that holds job names that are automatically triggered when the PR is created.

Example:

In case a job is changed which contains an annotation entry like so

          annotations:
            rehearsal.auto: pull-kubevirt-e2e-k8s-1.31-sig-compute,pull-kubevirt-e2e-kind-sriov
            rehearsal.required: true

a rehearsal of those jobs could be kicked off - additionally those rehearsals would be marked as required (TODO: need to check whether that is possible)

          /rehearse pull-kubevirt-e2e-k8s-1.31-sig-compute
		  /rehearse pull-kubevirt-e2e-kind-sriov

Originally posted by @dhiller in #3778 (comment)

@dhiller
Copy link
Contributor Author

dhiller commented Dec 5, 2024

/kind enhancement
/area automation
/priority backlog

@brianmcarey FYI

@kubevirt-bot kubevirt-bot added kind/enhancement area/automation Issues and PRs concerning automation, i.e. KubeVirt job updates, KubeVirtCI bumps etc. priority/backlog Indicate that the issue or PR is a lower priority and can be worked on in the future labels Dec 5, 2024
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Issues and PRs concerning automation, i.e. KubeVirt job updates, KubeVirtCI bumps etc. kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Indicate that the issue or PR is a lower priority and can be worked on in the future
Projects
None yet
Development

No branches or pull requests

2 participants