Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metrics port configuration from env to cli flag #787

Open
fabriziosestito opened this issue Jun 26, 2024 · 0 comments
Open

Move metrics port configuration from env to cli flag #787

fabriziosestito opened this issue Jun 26, 2024 · 0 comments

Comments

@fabriziosestito
Copy link
Contributor

Is your feature request related to a problem?

We provide a way to configure the port where the Policy Server will be exposing metrics to be collected, by using an environment variable.
However, this is the only env variable we expose, as the controller configuration is done by using cli flags.

Solution you'd like

We need to move the metrics configuration logic to the cmd/main.go file by using cli flags instead of using the golang init() function, and pass it to the reconciler as a member of the reconciler struct.

This involves changing the helm chart as well: 2
https://github.com/kubewarden/helm-charts/blob/76dd5ccad7b11a4346ab8fa58371f8f259511636/charts/kubewarden-controller/templates/deployment.yaml#L53

Alternatives you've considered

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant