Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt: webhooks should have the certificates set #854

Closed
Tracked by #493 ...
jvanz opened this issue Aug 26, 2024 · 2 comments · Fixed by #867
Closed
Tracked by #493 ...

tilt: webhooks should have the certificates set #854

jvanz opened this issue Aug 26, 2024 · 2 comments · Fixed by #867
Assignees
Milestone

Comments

@jvanz
Copy link
Member

jvanz commented Aug 26, 2024

In a recent change the root CA and the certificate used by the controller are bootstrapped by Helm. However, the Tiltfile used in the controller repository does not use the certificates generated by the Helm chart. Because it uses the configuration generated by the kustomize in the repository. Therefore, it is always running the latest webhooks configuration defined in the controller code. However, this cause issues because the controller does not have the certificates bootstrapped. Therefore, we need to update the Tiltfile to use the root CA generated by Helm together with the configurations generated by Kustomize locally.

Acceptance criteria

  • Check if the Helm execution in the Tiltfile genetates the required certificates
  • If the certificates are generated in the Tiltfile call, reuse them in the webhooks configuration together with the values generated by Kustomize locally.
  • If the certificates are not generated in the Helm call, generate the certificates in the Tiltfile and updates the webhooks configuration from Kustomize.
@flavio
Copy link
Member

flavio commented Aug 29, 2024

Thanks for pointing this out. We should get this done ASAP

@flavio
Copy link
Member

flavio commented Aug 29, 2024

CC @fabriziosestito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants