Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Params should occur one at a time #13

Open
runyontr opened this issue Mar 24, 2020 · 5 comments
Open

Updating Params should occur one at a time #13

runyontr opened this issue Mar 24, 2020 · 5 comments
Assignees

Comments

@runyontr
Copy link
Member

Since KUDO doesn't currently support updating multiple parameters at the same time, we can use Terraform to control the rollout and update of the instance.

@runyontr runyontr self-assigned this Mar 24, 2020
@alenkacz
Copy link
Contributor

it does not? I think it does support that, only all changes have to go to the same trigger

@runyontr
Copy link
Member Author

I believe you can update multiple params with different triggers, but only one of the plans runs. With the provider we could do them one at a time since we have an understanding of the before/after state and can see which set of params are changing as the plans run, and which are still outstanding.

Do you think we should upgrade all params of the same trigger at the same time, or do them one at a time regardless of whether they're the same plan or not?

Order is something we might also need to consider

@alenkacz
Copy link
Contributor

Yeah that is the behavior without webhook, with webhook, that request will be rejected.

Yeah that sounds like a good feature I just wonder how to determine the order in case of different triggers 🤔

@runyontr
Copy link
Member Author

https://github.com/kudobuilder/kudo/blob/dc7492401f96f8a3a774bd2d07d867feb72b5671/pkg/webhook/instance_admission.go#L290-L321

Thank you for the lead. I haven't had time to test with webhooks yet, but that's a great feature. I think I would still want this feature so that in a GitOps work flow we don't have to have multiple commits, each with the partial change.

@alenkacz
Copy link
Contributor

@runyontr yeah, that makes a ton of sense for gitops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants