Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website link check fail due to external website #2156

Closed
lahabana opened this issue Jan 23, 2025 · 2 comments · Fixed by #2172
Closed

website link check fail due to external website #2156

lahabana opened this issue Jan 23, 2025 · 2 comments · Fixed by #2172
Labels
triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

          I'm aware of this CI failure on the link checker: 

https://github.com/kumahq/kuma-website/actions/runs/12921742840/job/36036265367?pr=2153#step:6:49

I'm merging this PR bypassing the link check as we need more discussion on how to deal with these link-checking errors:

https://deploy-preview-2153--kuma.netlify.app/docs/2.8.x/production/cp-deployment/zoneproxy-auth/
	500	https://jwt.io/
https://deploy-preview-2153--kuma.netlify.app/docs/2.7.x/policies/meshproxypatch/
	lookup jsonpatch.com on 127.0.0.53:53: no such host	https://jsonpatch.com/

Research:

  • jwt.io is asking for a header -H 'accept-language: en-US'
  • We need to find a replacement of jsonpatch.com as it looks like down permanently

Originally posted by @jijiechen in #2153 (comment)

@github-actions github-actions bot added the triage/pending This issue will be looked at on the next triage meeting label Jan 23, 2025
@lahabana
Copy link
Contributor Author

For jsonpatch.com could we use: https://en.wikipedia.org/wiki/JSON_Patch ?

We can always set the header accept-language is common enough

@lukidzi
Copy link
Contributor

lukidzi commented Jan 27, 2025

Triage: Let's set accept-language all the time

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants