Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make MC updates independent from the diagram topology #2

Open
kunyuan opened this issue Jan 28, 2019 · 0 comments
Open

make MC updates independent from the diagram topology #2

kunyuan opened this issue Jan 28, 2019 · 0 comments
Labels
refactoring code refactoring

Comments

@kunyuan
Copy link
Owner

kunyuan commented Jan 28, 2019

Calculating the weight of a diagram only need to know the internal variables and the G and interaction functions. It does not rely on how G and interaction are topologically connected. Such observation can be used to make the code as generic as possible.

The following may be useful in the future:

  1. Each group in the diagram file should provide a list of independent variables, with external and internal variables separately marked. There is no need to provide diagram topology in principle.
  2. In the code, each group object maintains the same list of independent variables, and a list of related G and interactions.
  3. MC updates simply use these variables to calculate the weight of G and interaction.
@kunyuan kunyuan added the refactoring code refactoring label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring code refactoring
Projects
None yet
Development

No branches or pull requests

1 participant