-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 11 design language #8
Comments
After some consideration, I decided to go with
then enable Mica. Mica looks like 100% brightness/darkness and I prefer current Acrylic as default. It won't affect many people. WinUI 3.x has a way to check if Mica is supported but WinUI 2.x for UWP doesn't, at least it seems.
Another way is to add option to enable Mica but I think it's too much. Adding too many options will confuse users. |
Hello, thank you so much for your responses. I apologize for not responding sooner. Awesome, a theme setting is a fantastic middle ground. Thank you so much for adding it in the end, looks like a great middle ground! Also, thank you for all the explanations and thought/dev process behind it, helps understand why things work as they are. Is there a way to test the latest build with these changes of bookviewer? Or should I wait for a full release? |
You can download and build, but I think you should wait. I do all my work on the master branch (it's definitely not good habit but is simple and easy) so it's all there. It may takes some times (some days This Issue will be closed when it's released. |
v3.2.6.0 is in the Store now. Closing the issue. |
Great work! I didn't notice the artifact posted previously; sorry for not responding to it. However, it seems that Mica isn't working, the side panel is flickering with acrylic and a blank canvas when the theming is set to auto, and when I try to override it to just 'dark' it doesn't load at all. Any idea what's going wrong? |
Mica is not applied to Explorer tab. Explorer tab should look the same as before. It's only applied to the Viewer and Settings. If it looks like this, that's fine. I don't know about flickering but I haven't changed anything about Explore page other than overriding the theme as far as I remember. So I don't think there's a new glitch. Reason why Explorer is excluded is that Explorer and Viewer function are in separate projects. It is still possible to apply Mica but the code will be a bit too dirty and I like acrylic. |
Heya there, thanks for the quick answer. Yes, I'm aware that the explorer isn't affected by this change. The flickering happens in the sidebar only. And, the flickering only happens when I set it to Auto. Dark makes the transparency disappear altogether, and Dark Acrylic works well, showing just Acrylic. Only the new dark/light themes are affected - not the Acrylic versions. Note that in addition to looking darker, Mica material only samples the desktop wallpaper once to create its visualization and shouldn't reflect any other software in its transparency which I think the transparency does in this implementation (source in documents). In addition, selecting and unselecting both result in a fully opaque background, which doesn't happen under Acrylic. I'm not sure why the rendering is glitching on my end though, but it's perfectly fine when selecting Acrylic in the themes. Documents: |
OK. I'll investigate and reopen this. |
I rent a computer with Windows 11 and tested. I confirmed the issues you reported.
So Mica theme is temporary disabled in v3.2.7.0. It may be fixed in the future. |
Hello, first of all, this is a fantastic app, the best one I've tried so far. The main question I have is if there are plans to update this app to have the more rounded Windows 11 design language? I think having the new Mica/Tabbed material behind books would be absolutely incredible. At any rate, thanks for providing this excellent program. I'm definitely looking forward to what comes next.
The text was updated successfully, but these errors were encountered: