Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suffix link question in split_edge function #5

Open
zhangliyong opened this issue May 26, 2013 · 1 comment
Open

suffix link question in split_edge function #5

zhangliyong opened this issue May 26, 2013 · 1 comment

Comments

@zhangliyong
Copy link

Hello,

I read your code and Mark Nelson's C++ implementation, and find that you both have the line:
self.nodes[e.dest_node_index].suffix_node = suffix.source_node_index ### need to add node for each edge
in _split_edge function, as you mentioned your implementation is based on Mark Nelson's one,

I don't understand why this line is needed, this line seems that a node have a suffix link pointing to its parent node, and this seams not the suffix link meaning.

@jiamo
Copy link

jiamo commented Jul 26, 2014

this can be delete ?

because , in while loop , self.nodes[last_parent_node].suffix_node = parent_node
And I don't find a string to make test failed after delelte this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants