Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Mockingjay include Mockingjay-Swift.h ! #106

Open
MedAmineWinners opened this issue Feb 22, 2019 · 2 comments
Open

Check if Mockingjay include Mockingjay-Swift.h ! #106

MedAmineWinners opened this issue Feb 22, 2019 · 2 comments

Comments

@MedAmineWinners
Copy link

MedAmineWinners commented Feb 22, 2019

@kylef
For pod files that do not use use_frameworks!, testing with Mockingjay returns a build error!

<Mockingjay/Mockingjay-Swift.h> file not found

So it will be better for you to add something like this in your MockingjayURLConfiguration.m
to check if include /Mockingjay-Swift.h or not.

this will make life easier for developers who use your pod to unit test their frameworks.
I tried to make a ullRequest on it, but it's not possible for me like I don't have the rights

#if __has_include("Mockingjay-Swift.h")
    #import "Mockingjay-Swift.h"
#else
    #import <Mockingjay-Swift.h/Mockingjay-Swift.h>
#endif
@mihailsalari
Copy link

@kylef Please apply those changes, it works with them.

@fousa
Copy link

fousa commented Apr 12, 2019

@kylef I have the same problem, any idea when you can manage to merge this? We love Mockingjay here, and hope we can continue to use it. 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants