Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: donot register menu separator for selected attachments #370

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: donot register menu separator for selected attachments #370

wants to merge 2 commits into from

Conversation

ramonmi
Copy link
Contributor

@ramonmi ramonmi commented Feb 13, 2025

  • v1.0.3
    • Content menu list for selected regular items
      20250213_202051
    • Content menu list for selected attachment items
      20250213_202107
  • This PR
    • Do not register separator in content menu list for selected attachment items
      20250213_202155

@ramonmi
Copy link
Contributor Author

ramonmi commented Feb 13, 2025

This is more obvious when enabling numerous plugins.
20250213_203116

@l0o0
Copy link
Owner

l0o0 commented Feb 17, 2025

Thank you for your code😊

@ramonmi ramonmi force-pushed the hidden-separator-for-attachment-menu branch from 6247e35 to 0786526 Compare February 22, 2025 01:56
@ramonmi ramonmi force-pushed the hidden-separator-for-attachment-menu branch from 0786526 to 01b84e2 Compare February 22, 2025 02:06
@ramonmi
Copy link
Contributor Author

ramonmi commented Feb 22, 2025

  • 抱歉之前忽略了toplevel的PDF/CAJ等Chinese附件右键menu list是需要separator的，commit 01b84e2 已修复该问题
    20250222_094116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramonmi @l0o0