-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.3 代码审改 #374
base: main
Are you sure you want to change the base?
v1.0.3 代码审改 #374
Conversation
…add soeme utils and refactor code
<label data-l10n-id="how-to-update-translators" class="zotero-text-link"/> | ||
<label data-l10n-id="translators-dashboard" class="zotero-text-link"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<label data-l10n-id="how-to-update-translators" class="zotero-text-link"/> | |
<label data-l10n-id="translators-dashboard" class="zotero-text-link"/> | |
<label data-l10n-id="how-to-update-translators" class="zotero-text-link" is="zotero-text-link"/> | |
<label data-l10n-id="translators-dashboard" class="zotero-text-link" is="zotero-text-link"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我注意到这个 is
了,但是我写的时候并没有发现这个 is
对 UI 有什么实质影响,所以本着不增加多余代码的原则去掉了。现在经过搜索,发现一些 scss 在用,我会马上保持这个一致性。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只有带有这个 is 属性的文本链接才能拉起浏览器。
<div id="table-container"></div> | ||
</main> | ||
<footer> | ||
<div id="buttons" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里声明命名空间是刻意的吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
刻意的,button 在两个命名空间里都有,在此明示之。
Preference
转换器
translators_CN
退出后被删除;Zotero.File.checkFileAccessError
检查转换器的可访问性,引导用户解除”同步文件夹“导致的文件锁定。CSL 样式
l10n
zh-TW
本地化文件。代码风格
event
而非e
或ev
,try
语句的catch
子句参数统一为error
;===
、!==
);as xxx
)和@ts-ignore
都应该给出忽略类型检查的理由。其他