Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycle Bin instead of Delete #44

Open
Dracon09 opened this issue Jul 12, 2020 · 4 comments
Open

Recycle Bin instead of Delete #44

Dracon09 opened this issue Jul 12, 2020 · 4 comments

Comments

@Dracon09
Copy link

Describe the problem
If you pick the wrong "best" movie to keep then it deletes the other movies.

Describe any solutions you think might work
Would be nice if instead of deleting the files it moved them to a separate path "Recyle Bin"

Additional context
Running this from Unraid 6.8.3 in a docker

@imjuzcy
Copy link

imjuzcy commented Dec 20, 2020

I would like to see this too, but it uses Plex to delete the files instead of accessing the filesystem itself. So unless Plex supports moving the files (which is highly unlikely), it requires a lot of work to code the function to move the files to a recycle bin.

@imjuzcy
Copy link

imjuzcy commented Dec 21, 2020

Hey @Dracon09, I submitted a pull request to add a feature to record the paths of the files that are supposed to be removed without actually removing it. As you're running it in Docker, the path that Plex has (what this script will get) and the actual path in the container of this script might differ, I thought it might be more flexible if it just records the path and if you want you can write a few lines of bash code to actually move them.

In addition to that it might also give the flexibility for those who want to keep some duplicates instead of deleting all.

I'm not sure if you're still looking for this feature, given that it has been so long since you posted the issue, but check my fork in the meantime before @l3uddz accept the pull request.

@jbeck22
Copy link

jbeck22 commented Mar 16, 2023

Describe the problem If you pick the wrong "best" movie to keep then it deletes the other movies.

Describe any solutions you think might work Would be nice if instead of deleting the files it moved them to a separate path "Recyle Bin"

Additional context Running this from Unraid 6.8.3 in a docker

can you share your docker compose file?

@Dracon09
Copy link
Author

Used the docker image

https://hub.docker.com/r/mikenye/plex_dupefinder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants