Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for conditional settings #73

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Add support for conditional settings #73

merged 7 commits into from
Jul 18, 2024

Conversation

pvaneveld
Copy link
Collaborator

Fixes #

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

demeyerthom
demeyerthom requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@demeyerthom demeyerthom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you add the following to the Taskfile on the format command and run it?:

  format:
    cmds:
      - go fmt ./...
      - terraform fmt -recursive -write=true ./examples/

Should fix some other incorrect TF files

@pvaneveld pvaneveld marked this pull request as ready for review July 18, 2024 08:18
@pvaneveld pvaneveld requested a review from a team as a code owner July 18, 2024 08:18
@pvaneveld pvaneveld requested a review from demeyerthom July 18, 2024 08:18
@demeyerthom demeyerthom merged commit c454c0f into main Jul 18, 2024
2 checks passed
@demeyerthom demeyerthom deleted the addSupportForConditionalSettings branch July 18, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demeyerthom demeyerthom demeyerthom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvaneveld @demeyerthom