Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abort during delay when using cycle_time plugin #55

Open
philipstarkey opened this issue Jan 28, 2020 · 1 comment
Open

Implement abort during delay when using cycle_time plugin #55

philipstarkey opened this issue Jan 28, 2020 · 1 comment
Labels
bug Something isn't working minor

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


In PR #50, the "cycle_time" plugin, I did not implement handing the case where the user clicks the abort button whilst the experiment queue is waiting for the target time before running the next shot. Nothing is checking for the abort event whilst the queue is waiting, and this means the abort does not actually occur until after transition_to_buffered, which isn't what you want.

@philipstarkey philipstarkey added minor bug Something isn't working labels Apr 5, 2020
@zakv
Copy link
Contributor

zakv commented Jan 13, 2021

I believe this issue is actually resolved. The cycle_time plugin connects to the abort button here:

inmain(self.BLACS['ui'].queue_abort_button.clicked.connect, self._abort)

I briefly tried it out as well and was able to abort shots during the added delay period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

2 participants